Update zip with zip64, extended timestamps and UID/GID handling #8537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 4 files 227 suites 1h 43m 47s ⏱️ Results for commit 7bea184. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
prim_zip is planned to be removed so we remove usage of it in zip.
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
2 times, most recently
from
a1e63be to
068bce8
Compare
garazdawi
added
the
testing
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
from
068bce8 to
5f3df01
Compare
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
from
f176221 to
b94d382
Compare
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
4 times, most recently
from
1c0f6cb to
7d87e7b
Compare
On Windows if you write ctime it will change it, while on unix it does not. So we don't update ctime unless it is part of the archive which is never is.
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
from
4ca37b7 to
127ffea
Compare
garazdawi
force-pushed
the
lukas/stdlib/zip64
branch
from
7bea184 to
efc2de2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the zip module with support for:
It also cleans up the code in zip and fixes a bunch of bugs in corner cases.